ci: Detect unmerged release fixes to main. - #46
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: MinoruSekine/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
.github/workflows/detect_unmerged.yml (1)
14-16: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winDeclare the minimum
GITHUB_TOKENpermission.This job only reads repository contents and runs a local detector. The workflow does not declare
permissions, so its token scope depends on external defaults. Addcontents: readto prevent a permissive default from granting unnecessary access. GitHub recommends this permission foractions/checkout. (docs.github.com)Proposed fix
+permissions: + contents: read + jobs:🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/detect_unmerged.yml around lines 14 - 16, Add a read-only permissions declaration for the detect_unmerged job, granting only contents: read before its runs-on configuration. Keep the existing job behavior unchanged.Source: MCP tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/detect_unmerged.yml:
- Line 3: Update the workflow name in the top-level name declaration to “Detect
commits in the release branch that have not been merged to main.”
- Around line 26-28: Add the missing
.github/workflows/scripts/detect_unmerged.sh file to the repository before the
workflow step invokes it, ensuring it is executable and implements the expected
origin/main and origin/releng/v0 arguments used by the workflow.
---
Nitpick comments:
In @.github/workflows/detect_unmerged.yml:
- Around line 14-16: Add a read-only permissions declaration for the
detect_unmerged job, granting only contents: read before its runs-on
configuration. Keep the existing job behavior unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: MinoruSekine/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: d045e033-c24d-4e73-94c8-fd1527ac5da2
📒 Files selected for processing (1)
.github/workflows/detect_unmerged.yml
ef575c7 to
88fcc04
Compare
Summary by CodeRabbit