Skip to content

Fix agent workspace settings loading forever#4956

Merged
timothycarambat merged 1 commit intomasterfrom
4952-bug-agent-configuration-page-blank
Feb 2, 2026
Merged

Fix agent workspace settings loading forever#4956
timothycarambat merged 1 commit intomasterfrom
4952-bug-agent-configuration-page-blank

Conversation

@shatfield4
Copy link
Collaborator

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #4949
resolves #4952
resolves #4954

What is in this change?

  • Resolves bug where admin endpoint was trying to call SystemSettings.brief.agent_sql_connections()
  • .brief was removed in feat: Add ability to edit existing SQL agent connections #4848 so this no longer exists
  • This does expose SQL credentials to the frontend but we are protected by the admin and manager middlewares so the users that are allowed to see the credentials already had permission to see them inside the agent skills SQL tool

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

@shatfield4 shatfield4 linked an issue Feb 2, 2026 that may be closed by this pull request
Copy link
Contributor

@angelplusultra angelplusultra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timothycarambat timothycarambat merged commit 866e9ef into master Feb 2, 2026
1 check failed
@timothycarambat timothycarambat deleted the 4952-bug-agent-configuration-page-blank branch February 2, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants