refactor: Migrate system preferences to field-based endpoint and remove deprecated endpoint#4958
Open
angelplusultra wants to merge 3 commits intomasterfrom
Open
refactor: Migrate system preferences to field-based endpoint and remove deprecated endpoint#4958angelplusultra wants to merge 3 commits intomasterfrom
angelplusultra wants to merge 3 commits intomasterfrom
Conversation
…to new service by field | delete old endpoint and service
shatfield4
approved these changes
Feb 2, 2026
Collaborator
shatfield4
left a comment
There was a problem hiding this comment.
Fixed minor issue by destructuring settings object in CustomSiteSettings component.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Relevant Issues
resolves #4957
What is in this change?
Migrates all frontend usages of the deprecated
Admin.systemPreferences()service to the new field-basedAdmin.systemPreferencesByFields()service, then removes the deprecated endpoint and service.Changes:
text_splitter_chunk_size,text_splitter_chunk_overlap,max_embed_chunk_sizemeta_page_title,meta_page_faviconfooter_datafeature_flagsGET /admin/system-preferencesendpoint from serverAdmin.systemPreferences()method from frontendThis improves efficiency by only fetching the specific settings each component needs rather than fetching all system preferences.
Additional Information
The new endpoint
GET /admin/system-preferences-for?labels=field1,field2was already in place and working. This PR completes the migration by updating all consumers and removing the deprecated code.Developer Validations
yarn lintfrom the root of the repo & committed changes