fix(cli): sandbox feedback fixes (1.0.38)#2
Merged
Conversation
…ting, publish, ports, follow - cp/ls: guard against undefined host list (client.listHosts -> ?? []) and give a clear error pointing sandbox IDs to `miosa sandbox cp/ls` instead of crashing with "Cannot read properties of undefined (reading 'find')". - exec: printObject prints full stdout/stderr (no clipping); the 48-char cell clipping stays for table columns only. - exec/run: allowUnknownOption + allowExcessArguments so `bash -c "..."` passes through; joinCommandWords shell-quotes multi-word args so quoting survives. - publish: default --wait timeout 180s -> 600s; explicit --no-wait; clearer "still building" timeout message; attach to existing same-name deployment in a non-terminal state instead of creating a duplicate. - exec/run: --follow/--stream streams output via background logfile polling. - new `sandbox ports <id>` subcommand lists listening TCP ports (ss or /proc).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes confirmed client feedback on the sandbox CLI. Build clean (tsc), 173/173 tests pass.
Cannot read properties of undefined (reading 'find')):listHosts()returns?? []; top-level cp/ls now give a clear "usemiosa sandbox cp/ls" error for sandbox IDs instead of crashing.printObjectprints full stdout/stderr; 48-char cell clipping retained for table columns only.exec <id> bash -c "..."→ unknown option:allowUnknownOption+allowExcessArgumentson exec/run;joinCommandWordsshell-quotes multi-word args so quoting survives;--documented.--waittimeout 180s → 600s; explicit--no-wait; clearer "still building" message.--follow/--streamstreaming exec output.sandbox ports <id>subcommand.Version bumped 1.0.37 → 1.0.38.