Update - #102
Conversation
Miracle656
left a comment
There was a problem hiding this comment.
This PR can't close #77. #77 is "API contract tests with Dredd", which needs a Dredd configuration and a contract-test suite wired into CI — but the only change here is to README.md, and it actually breaks the setup instruction: cp .env.example .env becomes cp .env.example.env (the space is removed, so it copies to a single nonsensically-named file). CI is also failing (typecheck + integration).
To address #77, this needs the actual Dredd setup (e.g. a dredd.yml pointing at the OpenAPI spec + a CI job running dredd), not a README edit. Please either replace this with the real implementation or close it. Also revert the .env command change — the original cp .env.example .env was correct.
|
This change looks incorrect: it edits |
|
I've gone through every open PR now that the wave has closed, fixing things myself where a PR needed work rather than leaving it to sit. I can't do that here, and I want to explain why rather than leave this quietly open. The diff makes two changes, and both go the wrong way. The -cp .env.example .env
+cp .env.example.envThat removes the space between source and destination. The blank lines were load-bearing. The other change removes the blank line between each I've left this open rather than closing it, so it stays on the record. But I can't merge a change that breaks a documented setup step, and there's nothing else in the diff for me to keep — unlike the other PRs I reworked, where there was a real idea underneath that just needed fixing. If there was a rendering problem you were actually trying to fix, say what you were seeing and I'll take another look — a README that renders wrong somewhere is worth knowing about. |
close #77
Dredd run is green
Drift flagged on PR