Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for an alipay_id on plans and introduces an admin notification endpoint.
- Adds
alipay_idto thePlanmodel and includes it in thequery_detailsresponse - Implements a new
/notify_adminroute to forward request bodies to a configurable URL - Updates
main.py, configuration, and environment sample to wire up the notifier
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/plan/details.py | Include alipay_id in the details API response |
| src/database/init.py | Add alipay_id field to the Plan model |
| src/config/init.py | Add notify_admin_url to settings |
| main.py | Register notify_admin_router in the FastAPI app |
| .env.sample | Add NOTIFY_ADMIN_URL placeholder |
| src/notify_admin/init.py | Implement the notify_admin endpoint |
Comments suppressed due to low confidence (1)
src/plan/details.py:46
- Add or update tests to verify that the new
alipay_idfield is correctly serialized and returned byquery_details.
"alipay_id": p.alipay_id,
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.