Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the 20250502 release by refactoring the plan endpoints, adding a new details endpoint, introducing caching improvements, and integrating ICP lookup functionality.
- Introduce separate endpoints for plan summary and details with caching improvements.
- Add a new ICP endpoint and update database models for Plan and ICP.
- Update static file mounting to use a configurable directory.
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/plan/summary.py | New plan summary endpoint using a caching strategy. |
| src/plan/details.py | New plan details endpoint with afdian info validation. |
| src/plan/cache.py | Introduces caching for plan queries. |
| src/plan/init.py | Removed legacy plan endpoint. |
| src/database/init.py | Updated Plan model and added new ICP model. |
| src/config/init.py | Added static_app_dir setting. |
| src/ICP/init.py | New ICP query endpoint based on domain lookup. |
| main.py | Updated router imports and static files mounting based on config. |
Files not reviewed (1)
- .env.sample: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.