add unmanaged-kcp transport#3865
Closed
Molth wants to merge 1 commit intoMirrorNetworking:masterfrom
Molth:master
Closed
add unmanaged-kcp transport#3865Molth wants to merge 1 commit intoMirrorNetworking:masterfrom Molth:master
Molth wants to merge 1 commit intoMirrorNetworking:masterfrom
Molth:master
Conversation
Contributor
|
Got any performance benchmarks to back up these claims? That'll boost possibility of getting it merged into Mirror mainline. |
Collaborator
|
@Molth is this still worth it over threaded C# kcp? and have you compared this against IL2CPP compiled kcp? there are a few reasons why we chose pure C# for kcp:
|
Contributor
|
after a quick look, I would guess the increase in performance is from using the unsafe/unmanaged code itself shouldn't give any major performance increase over managed c#, because all that will do is skip safety bounds checks on arrays. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.