-
-
Notifications
You must be signed in to change notification settings - Fork 793
perf: Reduce Message Noise #3979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
High Ping frequency and TimeSnapshotMessage are only needed when NT's are actively used in the game - Prevents TimeSnapshotMessage sending when no NT's - Uses 2s Ping frequency when no NT's - NetworkTime has a `static ulong activeNTs' - NTBase and NTHybrid increment / decrement via OnEnable / OnDisable - Tests updated to use DefaultPingInterval, now internal static instead of const Tested with PlayerTest, Basic, and Room examples - PlayerTest works as expected using all NT prefabs - Basic example has no NT's, works as expected with low noise - Room example only uses NT in Game scene, not in Online scene - Logging shows the higher msg traffic in Game scene only, not in Online scene (correct) - Logging shows the reduced msg traffic when in Online Scene, even when switching back to Online scene from Game scene
Why is |
A few reasons:
Basically, any component (NT, PredictedRB, future others) has to tell NetworkTime they're alive, so the rest of Mirror uses the correct timing and sends the required messages. |
Fixes #3828
High Ping frequency and TimeSnapshotMessage are only needed when NT's / PredictedRB's are actively used in the game
static ulong highPingComponents
Tested with PlayerTest, Basic, BilliardsPredicted, and Room examples