test(NetworkManagerHUD): add unit test#4109
Draft
Nietod wants to merge 1 commit intoMirrorNetworking:masterfrom
Draft
test(NetworkManagerHUD): add unit test#4109Nietod wants to merge 1 commit intoMirrorNetworking:masterfrom
Nietod wants to merge 1 commit intoMirrorNetworking:masterfrom
Conversation
Added unit test for the NetworkManagersHUDs lifecycle and attributes. Not sure about the OnGUI Methods. Found some workaround by using delegates but could be overengineered and not suitable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added unit tests for the NetworkManagersHUDs lifecycle and attributes.
Not sure about the OnGUI Methods. Found some workaround by using delegates but could be overengineered and not suitable.
Guess can't really do OnGUI within EditModeTests.
Making this one Draft until clear instructions on how to handle OnGUI.