Add OnError for SocketException #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On windows, when trying to connect to localhost, there seems to be an edge case where instead of timing out or anything like that, windows knows better and raises a socket exception here: "System.Net.Sockets.SocketException (0x80004005): An existing connection was forcibly closed by the remote host.", which of course doesnt make any sense whatsoever if there's not a server listening to begin with (should be a connection refused really), but thats how it is
miwarnec
force-pushed
the
master
branch
2 times, most recently
from
4e43d57 to
a18854b
Compare
miwarnec
force-pushed
the
master
branch
3 times, most recently
from
d6ae9fe to
eeb25ed
Compare
miwarnec
force-pushed
the
master
branch
2 times, most recently
from
ec826db to
5e2ef37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows, when trying to connect to localhost, there seems to be an edge case where instead of timing out or anything like that, windows knows better and raises a socket exception here: "System.Net.Sockets.SocketException (0x80004005): An existing connection was forcibly closed by the remote host.", which of course doesnt make any sense whatsoever if there's not a server listening to begin with (should be a connection refused really), but thats how it is