- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 928
 
Release - v2.3.8 #3046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            JAForbes
  wants to merge
  19
  commits into
  release
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
main
  
      
      
   
  
    
  
  
  
 
  
      
    base: release
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            Release - v2.3.8 #3046
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Signed-off-by: Olexandr88 <[email protected]>
Bumps the normal group with 1 update: [actions/setup-node](https://github.com/actions/setup-node). Updates `actions/setup-node` from 4 to 5 - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: normal ... Signed-off-by: dependabot[bot] <[email protected]>
setImmediate() is not supported in almost all environments except IE11. Furthermore, by not using setImmediate(), the assignment code to callAsync itself, which takes non-browser environments into account, can be removed.
The `window` is no longer used within m.render().
The bundle size can be reduced by removing the intermediate object used to export domFor and delayedRemoval. Additionally, the file paths used in domFor-related require() calls have been standardized.
…ith one shared version
…undle by changing the module loading order and variable name Mithril's internal bundler enables module bundling without generating intermediate variables by carefully managing module loading order and variable names. This commit prevents assigning `mountRedraw`, `decodeURIComponentSave`, and `hyperscript` to intermediate variables. It also improves readability by moving all member additions for `m` to the end of the file.
Some router-related tests have fixed issues where UTF-8 strings were not decoded.
… types This will make the results more consistent with decodeURIComponent.
…rect mangling by internal bundler
Because "c" was being improperly mangled and the "c0" suffix was being improperly removed, it was changed to "c[01]" rather than just dropping the literal use.
Also, since the backslash in "\d" is escaped ("\\d"), I simply changed it to "0-9" of the same string length.
    …n the internal bundler This allows regular expression literals to be used even where RegExp() was previously used as a workaround.
Like the issue addressed in #3000, it seemed that the performance of mithril.min.js had degraded again. I tried some compression options for terser and found that disabling the `conditionals` option improved performance and also reduced the bundle size.
It seemed that, for example, `var i` might cause a suffix to be added to the "i" flag within a regular expression literal. So the entire regular expression literal, including flags, is now corrected within the bundler.
Bumps the normal group with 1 update: [actions/setup-node](https://github.com/actions/setup-node). Updates `actions/setup-node` from 5 to 6 - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v5...v6) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major dependency-group: normal ... Signed-off-by: dependabot[bot] <[email protected]>
…cy checks after normalization This change preallocates the array to the input length and collapses multiple loops into a single pass. Assigning immediately after preallocation improves performance on V8 (generally neutral elsewhere). Key checks are now performed on normalized vnodes, making the consistency validation more accurate and clarifying the correspondence between error messages and code. Perf-sensitive comments have been clarified to reflect the original intent of commit 6c562d2. Behavior is unchanged, except that the timing/order of related errors may differ slightly. All existing tests pass. Additionally, bundle size is slightly reduced.
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    dependencies
  Pull requests that update a dependency file 
  
    github_actions
  Pull requests that update GitHub Actions code 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Release v2.3.8
Vnode.normalizeChildren#3052Changelog
Patch Changes
refactor
Vnode.normalizeChildren(@kfule)Vnode.normalizeChildrennow preallocates the array length and performs key-consistency checks after normalization.Bump actions/setup-node from 5 to 6 in the normal group (@dependabot[bot])
Bumps the normal group with 1 update: actions/setup-node. Updates
actions/setup-nodefrom 5 to 6. Release notes.Fix URI decoder bug and reduce bundle size through module tailoring and cleanup (@kfule)
This fixes the URI decoder used in the Router to decode more strictly.
Bump actions/setup-node from 4 to 5 in the normal group (@dependabot[bot])
Bumps the normal group with 1 update: actions/setup-node. Updates
actions/setup-nodefrom 4 to 5. Release notes.docs: edited the link to the build badge (@Olexandr88)