-
Notifications
You must be signed in to change notification settings - Fork 160
Merge XRI3 update into main #1083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
keveleigh
wants to merge
454
commits into
main
Choose a base branch
from
feature/XRI3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added XRI3+ versions of SolverHandlerTests SolverHandlerInteractorLeftHandOnly, SolverHandlerInteractorMovesWithHand, SolverHandlerInteractorPreferredHandedness, SolverHandlerInteractorRightHandOnly, SolverHandlerInteractorSwitchesToActiveHand, SolverHandlerInteractorSwitchesToActiveHandWithEverythingValue, and SolverHandlerInteractorTracksInitialActiveHand.
…entAction() logic to handle deprecated XRController selectAction and ControllerLess SelectInput actions
In this PR: * Upgraded TapToPlace::RegisterPlacementAction() and TapToPlace::UnregisterPlacementAction() logic to handle both deprecated XRController selectActions and new XRI3+ Interactor's selectInput actions. * Added XRI3+ versions of SolverTapToPlaceTests TapToPlaceFollowsRightHandRay and TapToPlaceFollowsLeftHandRay.
In this PR: * Added XRI3+ versions of MRTKRayInteractorVisualsTests ReticleAndLineVisualActiveTest.
…line, while investigating the issue.
* Added XRI3+ versions of FuzzyGazeInteractorTests. * Fixing some input action references in MRTK XRI3+ rig.
* Adding ControllerlessRigSmokeTest * Making some interactor properties public so that they can be tested. * Added InputTestUtilities.RigReference to facilitate testing.
For the goal of having a way to test the (soon to be) deprecated pre-XRI3 rig, in this PR: * Made a copy of the existing HandInteractionExample and named it ObsoleteHandInteractionExample * Updated scene description panel, it now looks like this:  * Added ObsoleteHandInteractionExample scene to default build settings.
…1018) Increase pen interactor collider to improve usability
* Update editor version * Update Unity versions of 4.0 packages * Update AndroidXRConfig.cs.meta * Remove 2021-specific #ifs * Min version to 2022.3.6f1 * Update CHANGELOGs
* Add new input action focus handling * Update Core * Update MRTKLifecycleManager.cs
* Revert "[XRI3] Updating `ObjectManipulator` so to not rely on obsolete XRI controllers. (#822)" This reverts commit ab47631. * Remove unused method that was referring to XRController * Update MRTKRayInteractor.cs * Some docs updates Signed-off-by: Kurtis <[email protected]> * Update ObjectManipulator.cs * Update CHANGELOG.md Signed-off-by: Kurtis <[email protected]> --------- Signed-off-by: Kurtis <[email protected]>
* Style update * Update InteractablePulse.cs * Add migration path for handedness * Actually, this is assigned at runtime, so not usable at serialization time * Update interface lists * Improve fallback logic * Update changelogs and package preview versions * Update GazePinchInteractor.cs
* Remove HandNode from HandModel Signed-off-by: Kurtis <[email protected]> * HandNode * Update CHANGELOG.md --------- Signed-off-by: Kurtis <[email protected]>
* Remove obsolete field * Clarify the version origin of newly deprecated items, as well as removing some stale obsolete code Signed-off-by: Kurtis <[email protected]> * Update InteractionModeManager.cs --------- Signed-off-by: Kurtis <[email protected]>
Merge main into feature/XRI3
Keeping things up-to-date
All tests pass:
<img width="138" height="36"
alt="{603272F5-6CF6-4A13-BBF3-6813B7E0429E}"
src="https://github.com/user-attachments/assets/9994f382-4802-47b0-a450-383b89e69874"
/>
Update EditorProjectUtilities.cs
…Hand Interaction Profile actions (#1040) * Remove unused overrides * Update MRTK Default Input Actions.inputactions Signed-off-by: Kurtis <[email protected]> * Be more specific about "select" Signed-off-by: Kurtis <[email protected]> * Be more specific about a few more mappings * Update MRTK Default Input Actions.inputactions * Fix synthetic hand readings * Add new "grab" actions for the grab interactor * Add MRTKSimulatedController to grab mappings * Update MRTK Default Input Actions.inputactions * Update CHANGELOG.md * Add Hand Interaction Profile to PC and Android OpenXR settings * Regenerate OpenXR settings --------- Signed-off-by: Kurtis <[email protected]> Signed-off-by: Kurtis <[email protected]>
32 tasks
* Re-add FindObjectUtility (and obsolete it) * Update CHANGELOG.md * Re-add BoundsHandleInteractable's migration path, as we haven't even had a 3.x release with it yet
* Update changelog versions * Update update-versions.ps1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1074
Fixes #645