Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR polishes user-facing text by fixing typos/grammar, standardizing capitalization, and renaming a few localization keys so the UI can reference correctly spelled identifiers.
Changes:
- Rename localization keys:
nowAnAddmin→nowAnAdmin,unknowError→unknownError,unlockWithWasscode→unlockWithPasscode, and update call sites. - Improve/standardize multiple English strings in
intl_en.arband regenerate localization outputs. - Capitalize and clarify a few device-transfer/menu labels.
Reviewed changes
Copilot reviewed 13 out of 21 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lib/widgets/window/menus.dart | Updates the debug menu label capitalization for device transfer. |
| lib/widgets/message/item/system_message.dart | Switches to the corrected localization key nowAnAdmin. |
| lib/widgets/auth.dart | Switches to the corrected localization key unlockWithPasscode. |
| lib/utils/device_transfer/device_transfer_dialog.dart | Updates device transfer UI strings (capitalization/wording). |
| lib/ui/landing/landing.dart | Switches to the corrected localization key unknownError. |
| lib/l10n/intl_zh.arb | Renames corrected keys (nowAnAdmin, unknownError, unlockWithPasscode). |
| lib/l10n/intl_zh-TW.arb | Renames corrected keys (nowAnAdmin, unknownError, unlockWithPasscode). |
| lib/l10n/intl_zh-HK.arb | Renames corrected keys (nowAnAdmin, unknownError, unlockWithPasscode). |
| lib/l10n/intl_ru.arb | Renames corrected key (nowAnAdmin). |
| lib/l10n/intl_ja.arb | Renames corrected key (nowAnAdmin). |
| lib/l10n/intl_es.arb | Renames corrected key (nowAnAdmin). |
| lib/l10n/intl_en.arb | Fixes many English strings and renames corrected keys. |
| lib/generated/l10n.dart | Regenerated localization accessors; includes renamed keys and updated messages. |
| lib/generated/intl/messages_zh.dart | Regenerated message map for renamed keys. |
| lib/generated/intl/messages_zh-TW.dart | Regenerated message map for renamed keys. |
| lib/generated/intl/messages_zh-HK.dart | Regenerated message map for renamed keys. |
| lib/generated/intl/messages_ru.dart | Regenerated message map for renamed keys. |
| lib/generated/intl/messages_ja.dart | Regenerated message map for renamed keys. |
| lib/generated/intl/messages_es.dart | Regenerated message map for renamed keys. |
| lib/generated/intl/messages_en.dart | Regenerated message map for updated English strings and renamed keys. |
| lib/app.dart | Switches to the corrected localization key unknownError. |
Comments suppressed due to low confidence (1)
lib/widgets/window/menus.dart:280
- This menu item label is hard-coded while the surrounding menu labels use
context.l10n.*. To keep the window menu translatable/consistent, please add a localization key for this label and use it here (even if it’s currently behindkDebugMode).
PlatformMenuItem(
label: 'Chat Backup and Restore',
onSelected: signed
? () {
showDeviceTransferDialog(context);
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
109
to
114
| CellGroup( | ||
| padding: const EdgeInsets.symmetric(horizontal: 20), | ||
| child: CellItem( | ||
| title: const Text('sync from other device'), | ||
| title: const Text('Sync from Another Device'), | ||
| onTap: () { | ||
| context.read<_NavigatorCubit>().push( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.