add back ODU Modulation#44
Open
LXXero wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a PR against the old infinitude module to add ODU Modulation support. This was apparently closed, and it mentions IDU support is in this new version - however - there's still no ODU support.
See old issue here:
MizterB/homeassistant-infinitude#57
I raised a new PR to add ODU support that should work with both heat pumps and variable speed compressors.
There was another PR here for this which added this support hard-coded for heatpumps:
#34
I tried to keep things more generic in this PR to avoid needing separate sensors for "heatpump" vs "variable compressor", by presenting "odu_modulation" as the sensor instead