bug fix in MMG5_split6(): face tags were taken from the wrong, uninitialized variable#296
Merged
corentin-prigent merged 2 commits intoMmgTools:developfrom Mar 24, 2025
Merged
Conversation
…ialized, variable. Since these tags are used to set tags for newly created edges, the bug led to warning messages from MMG5_chkedg() about inconsistency between point and edge tags.
corentin-prigent
approved these changes
Mar 24, 2025
Contributor
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MMG5_split6 function was using face tags taken from an uninitialized variable. Since these tags are used to set tags for newly created edges, the bug led to warning messages from MMG5_chkedg() about inconsistency between point and edge tags. With some instrumentation I have seen that only the split6 function had this problem, likely because it is implemented a bit differently than the other split functions. Btw I will propose a reorganization of this function later.