New option -fem replacing -nofem#298
Open
corentin-prigent wants to merge 18 commits intoMmgTools:developfrom
Open
New option -fem replacing -nofem#298corentin-prigent wants to merge 18 commits intoMmgTools:developfrom
-fem replacing -nofem#298corentin-prigent wants to merge 18 commits intoMmgTools:developfrom
Conversation
…ecting feature points (ridge or non-manifold)
…com:corentin-prigent/mmg into feature/split-nonrid-edg-connecting-rid-pts
…tive, the test is ( if (mesh->info.fem) )
…-connecting-rid-pts
…-connecting-rid-pts
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #298 +/- ##
===========================================
- Coverage 50.31% 50.31% -0.01%
===========================================
Files 177 177
Lines 47881 47894 +13
Branches 10362 10368 +6
===========================================
+ Hits 24093 24097 +4
- Misses 16047 16054 +7
- Partials 7741 7743 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Also, can you please update the comments documenting info.setfem and info.fem in libmmgtypes.h |
Contributor
|
And add a test for option setfem=2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update removes the option
-nofemand adds a new option-femwhich takes an integer as a parameter:-fem 0mimics the exact behaviour of-nofem.-fem 1is the default behaviour: mmg forces the output mesh to be finite element compatible.-fem 2adds the option to also prevent the creation of regular boundary edges linking two features points (ridges or non-manifold). This stems from PR Force the split of regular boundary edges connecting ridge or non-manifold vertices #229.