Fix address sanitizer being incorrectly applied to host tools - #3317
Open
adincebic wants to merge 1 commit into
Open
Fix address sanitizer being incorrectly applied to host tools#3317adincebic wants to merge 1 commit into
adincebic wants to merge 1 commit into
Conversation
Signed-off-by: Adin Cebic <cebic.ad@gmail.com>
Contributor
Author
|
Perhaps we should not disable the features for host. |
| --copt=-Wno-macro-redefined | ||
| --copt=-D_FORTIFY_SOURCE=0 | ||
| ) | ||
| build_pre_config_flags+=(--features=asan --host_features=-asan) |
Contributor
There was a problem hiding this comment.
There is historical reasons for using the raw flags instead of the features. I don't recall what is it, but I think Git history will tell.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling Address Sanitizer caused the app to fail to build because sanitizer flags were also being applied to host tools. Since host tools do not need to be sanitized when sanitizing the app, we use Bazel features to disable those flags for host tools while leaving the app target unchanged.