Skip to content

Fix Testing.framework rsync exclusion - #3321

Open
louwers wants to merge 1 commit into
MobileNativeFoundation:mainfrom
louwers:codex/fix-testing-framework-rsync-exclusion
Open

Fix Testing.framework rsync exclusion#3321
louwers wants to merge 1 commit into
MobileNativeFoundation:mainfrom
louwers:codex/fix-testing-framework-rsync-exclusion

Conversation

@louwers

@louwers louwers commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

This seems like a real issue. See the diff, it's a small patch.

GPT 5.6 wrote the text below.

What does this change?

Remove the trailing comma from the Testing.framework entry in the Bash array used to generate rsync exclusions.

The comma is currently emitted as part of the filename:

/*.app/Frameworks/Testing.framework,

That pattern does not exclude the real Testing.framework. The Bazel output-copy script can consequently run rsync --delete against the framework while Xcode is copying it into a test host, causing timing-dependent build failures.

Observed failures include a missing Testing.framework/Info.plist and unlinkat: Directory not empty:

https://github.com/maplibre/maplibre-native/actions/runs/29261436369/job/86881585165?pr=4146

Downstream workaround PR: maplibre/maplibre-native#4402

Validation

  • bazel run //:buildifier.check
  • bazel build //xcodeproj/internal/bazel_integration_files:rsync_excludes
  • Confirmed the generated app exclusions contain Testing.framework without a trailing comma for both framework locations

@louwers
louwers requested a review from a team as a code owner July 13, 2026 20:57
Signed-off-by: Bart Louwers <bart@emeel.net>
@adincebic
adincebic enabled auto-merge (squash) July 14, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants