Replace bundled rsync with a clonetool based copy_tool - #3323
Open
john-flanagan wants to merge 1 commit into
Open
Replace bundled rsync with a clonetool based copy_tool#3323john-flanagan wants to merge 1 commit into
john-flanagan wants to merge 1 commit into
Conversation
Signed-off-by: John Flanagan <github@jflan.com>
john-flanagan
force-pushed
the
jflan/copy-tool
branch
from
July 30, 2026 02:03
3702bab to
4c249e8
Compare
john-flanagan
commented
Jul 30, 2026
Comment on lines
+196
to
+197
| parser.add_argument("--delete", action="store_true") | ||
| parser.add_argument("--exclude-from", default=None) |
Contributor
Author
There was a problem hiding this comment.
We always pass --delete so I could remove this argument, but it seemed weird to me to have the --exclude-from argument without a explicit --delete argument too 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take advantage of APFS clones when copying files out of the Bazel output base.
Also breaks our dependency on either system or bundled
rsync.