Skip to content

[BA-2211] Update the SDK constructor to accept the new originVerification property #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sakethkotamraju wants to merge 8 commits into from
Closed

[BA-2211] Update the SDK constructor to accept the new originVerification property #35

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b1cdfe0
key generation script for well known file
sakethkotamraju Jun 26, 2025
d733c46
init commit for domain verification in sdk constructor
sakethkotamraju Jun 27, 2025
96dabf4
added originVerification to constructor
sakethkotamraju Jul 1, 2025
00f3c37
minor fixes
sakethkotamraju Jul 2, 2025
6ac8c52
changed 'requestNonce' to 'getNonce' &
sakethkotamraju Jul 2, 2025
8f6c3df
switched 'originVerification to domainVerification' & removed 'wallet…
sakethkotamraju Jul 10, 2025
01d1a82
removed console.logs for lint
sakethkotamraju Jul 11, 2025
cef8b11
fixes to prevent CI error
sakethkotamraju Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions packages/client/scripts/generate-domain-keys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ function generateDomainVerificationKeys() {

function main() {
try {
console.log('🔑 Generating Base domain verification keys...\n');

const { jwks, privateKey } = generateDomainVerificationKeys();

Expand All @@ -67,19 +66,7 @@ function main() {
// Write the private key to a separate file in the project root directory
const privateKeyPath = join(projectRoot, 'domain-verification-private-key.txt');
writeFileSync(privateKeyPath, privateKey);

console.log('✅ Successfully generated domain verification keys!\n');
console.log('📁 Files created:');
console.log(` • ${jwksPath} - JWKS file for your domain`);
console.log(` • ${privateKeyPath} - Private key (keep this secure!)\n`);

console.log('🌐 Next steps:');
Copy link
Copy Markdown
Collaborator

@fan-zhang-sv fan-zhang-sv Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it makes sense to have these log in the script tho, maybe we can disable this rule for /scripts/ folder?

Copy link
Copy Markdown
Author

@sakethkotamraju sakethkotamraju Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to remove them because they kept failing the CI

console.log(' 1. Host the base-jwks.json file at: https://yourdomain.com/.well-known/base-jwks.json');
console.log(' 2. Store the private key securely for use with the SDK');
console.log(' 3. Use the private key with the SDK\'s generateSignature function\n');

} catch (error) {
console.error('❌ Error generating domain verification keys:', error);
process.exit(1);
}
}
Expand Down
Loading