Skip to content

[WIP] Modifications to acceptance ratio from Moves #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

sgill2
Copy link
Collaborator

@sgill2 sgill2 commented Jan 16, 2018

This PR allows the Move class the option to directly impact the acceptance ratio of a move by the Move.acceptance_ratio attribute. This can potentially come into effect in a variety of circumstances for example, due to dart overlap in Smart Darting. The log of the Move.acceptance_ratio is added to the protocol work to get the overall acceptance ratio during the acceptRejectNCMC() portion of the simulation.

Also in the case when Move.acceptance_ratio == 0 at either the beginning of the NCMC iteration, or after the Move.move() method takes place, the entire NCMC portion is automatically rejected. This can come up in numerous places as well, like @khburley's dihedral rotational moves within specific regions where you wouldn't want to continue calculations if the dihedral ends up outside those regions.

@stevenayoub
Copy link
Collaborator

@davidlmobley
This can be closed if we decide to merge the side chain bias pull request (#160: #160), as it introduces acceptance_ratio as a per-move parameter to optionally skip NCMC integration when a move is known to be unproductive (e.g., rotamer rejection in SideChainMove).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants