Add ucm-toolkit for posix aio test&nic monitor and copy bandwidth test#1012
Open
harrisonyhq wants to merge 8 commits into
Open
Add ucm-toolkit for posix aio test&nic monitor and copy bandwidth test#1012harrisonyhq wants to merge 8 commits into
harrisonyhq wants to merge 8 commits into
Conversation
harrisonyhq
requested review from
FangRun2,
Tarrei,
mag1c-h and
ygwpz
as code owners
ygwpz
reviewed
Jun 10, 2026
ygwpz
reviewed
Jun 10, 2026
ygwpz
reviewed
Jun 10, 2026
| std::vector<const CopyBuffer*> srcBuffers(ctx.nDevice); | ||
| std::vector<const CopyBuffer*> dstBuffers(ctx.nDevice); | ||
| for (size_t device = 0; device < ctx.nDevice; device++) { | ||
| srcBuffers[device] = new HostCopyBuffer{device, ctx.size, ctx.num}; |
Contributor
There was a problem hiding this comment.
🔴 Critical: Memory allocation with new followed by instance.DoCopyBatch(...) without exception handling. If DoCopyBatch throws an exception, the HostCopyBuffer and DeviceCopyBuffer objects will not be deleted, causing memory leaks. Consider wrapping this in a try-catch block or using smart pointers (e.g., std::unique_ptr).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add
ucm-toolkitas a unified CLI entry for POSIX AIO testing, NIC monitoring, and copy bandwidth testing.Modifications
ucm-toolkitpackage and CLI entry point.posix-aio,nic-monitor, anddev-sandboxtooling.Test