Skip to content

chore: recreated gpboost man file, added conditional tests for suggested packages#52

Merged
mayer79 merged 14 commits into
ModelOriented:masterfrom
kapsner:master
Apr 22, 2026
Merged

chore: recreated gpboost man file, added conditional tests for suggested packages#52
mayer79 merged 14 commits into
ModelOriented:masterfrom
kapsner:master

Conversation

@kapsner

@kapsner kapsner commented Feb 1, 2026

Copy link
Copy Markdown
Contributor

fixes currently failing unit tests

restored expected behaviour of 'predictions from unified == original predictions'
by now controlling the 'base_score' parameter in order
to prevent automated calculation of the intercept, as it was
introduced to xgboost with v2 and later versions
renamed argument 'model' -> 'model_name' to avoid issues
with also used object named 'model'
as split value is considered to be 'less than'
renamed globals.R -> zzz.R and moved all import statements there
@kapsner

kapsner commented Mar 3, 2026

Copy link
Copy Markdown
Contributor Author

@pbiecek @mayer79 any updates on the CRAN submission? This PR fixes some issues with the man pages, probably required for a successful submission. Let me know, if anything needs to be added in this regard. Best, Lorenz

@kapsner

kapsner commented Apr 20, 2026

Copy link
Copy Markdown
Contributor Author

ping

@pbiecek

pbiecek commented Apr 20, 2026

Copy link
Copy Markdown
Member

@mayer79 In the DESCRIPTION file, I’ve changed your role to ‘cre’, and the previous maintainers support the idea of you stepping into this role (if you’d like to)
Let me know if that’s OK with you and whether you’ll upload this package to CRAN
(I could do it too, though that would probably be the slowest option)

@mayer79

mayer79 commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

👍 "cre" sounds strange, but its correct according to CRAN. I will bring treeshap back to CRAN.

@mayer79
mayer79 merged commit 6bb80d2 into ModelOriented:master Apr 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants