Refactor get_problem to serialize group permissions correctly #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KanonKC
requested changes
Aug 20, 2025
api/services/problem_service.py
Outdated
| domain = request.get_host() | ||
| pdf_filename = problem.pdf_url | ||
| problem.pdf_url = f"http://{domain}/media/import-pdf/{pdf_filename}" | ||
| problem.pdf_url = f"http://{domain}/media/import-pdf/{pdf_filename}" if pdf_filename else "" |
There was a problem hiding this comment.
ตอนที่ขึ้น Production แล้ว Domain ของเราจะขึ้นต้นด้วย https:// แทน เพราะงั้นอาจจะต้อง Handle กรณีนี้ด้วย
There was a problem hiding this comment.
อันนี้ผมลองทำละ แต่ยังไม่ได้testแบบ https
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
อันนี้ทำใหม่ อันที่แล้วลวกไปหน่อยแล้วมันใช้กับ frontend ไม่ได้5555 ผมฝาก merge หน่อยคับ