fix(ci): use --workspace so release builds darktide-ffi artifacts - #26
Merged
Conversation
The v0.2.0 release failed because the packaging step could not find libdarktide_ffi.so / libdarktide_ffi.a in target/release/. Root cause: this repo has a root [package] (darktide-extractor-cli) plus a [workspace] declaration. In that layout, plain 'cargo build' only builds the root package and its dependencies (darktide-bundle). darktide-ffi is a sibling workspace member that nothing depends on, so cargo silently skips it. The dtex binary builds fine, but no FFI artifacts are produced. Fix: add --workspace to force cargo to build every workspace member, including darktide-ffi's cdylib + staticlib + rlib targets. Verified locally that the expected artifacts (libdarktide_ffi.so, libdarktide_ffi.a, dtex) are produced.
ModifAmorphic
pushed a commit
that referenced
this pull request
Jun 15, 2026
🤖 I have created a release *beep* *boop* --- ## [0.2.1](v0.2.0...v0.2.1) (2026-06-15) ### Bug Fixes * **ci:** use --workspace so release builds darktide-ffi artifacts ([#26](#26)) ([8c23aa6](8c23aa6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hotfix for the v0.2.0 release failure. The packaging step failed with:
Root cause
This repo has a root
[package](darktide-extractor-cli) plus a[workspace]declaration. In that layout, plaincargo builddefaults to building only the root package and its dependencies (darktide-bundle).darktide-ffiis a sibling workspace member that nothing depends on, so cargo silently skips it. Thedtexbinary builds fine, but no FFI artifacts are produced.Reproduced locally before fixing:
Fix
Add
--workspaceto force cargo to build every workspace member, includingdarktide-ffi's cdylib + staticlib + rlib targets:Verified locally that the expected artifacts (
libdarktide_ffi.so,libdarktide_ffi.a,dtex) are produced.Note on v0.2.0
v0.2.0 was already tagged and a (prerelease) GitHub Release was created with zero assets. This fix unblocks future releases but does not retroactively backfill v0.2.0. Recovery options for v0.2.0 specifically will be discussed separately — likely either delete the v0.2.0 release+tag and let release-please re-cut on the next feat/fix commit, or leave v0.2.0 as a prerelease with no assets and let v0.2.1 be the first properly-shipped release.
Verification
cargo build --release --workspaceproducestarget/release/libdarktide_ffi.so,target/release/libdarktide_ffi.a, andtarget/release/dtex.