[fix] Shift-F5 being falsely inserted as 'S-F5'#2234
Merged
da-liii merged 1 commit intoMoganLab:branch-1.2from Jun 5, 2025
Merged
[fix] Shift-F5 being falsely inserted as 'S-F5'#2234da-liii merged 1 commit intoMoganLab:branch-1.2from
da-liii merged 1 commit intoMoganLab:branch-1.2from
Conversation
Contributor
|
这个好,我看了没问题。等明天沈达再review一下。 BTW,师弟加个微信,haggittli |
Contributor
|
same problem as #2233 |
Contributor
|
@da-liii macOS arm64的CI挂了,貌似和我本地端一个问题,看看是不是xmake的配置有问题 |
da-liii
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Resolved the issue where
Shift-F5was incorrectly interpreted asS-F5by adding a simple check:comb != "S-F5"during fallback.Related: #2217
Why
Though this may not be the most elegant solution, it effectively addresses the issue for now, I think.
How to test your changes
$Shift+F5orShift+F5+IorShift+F5+OorShift+F5+UorShift+F5+N(possibly with the Fn key)S-F5