Skip to content

Comments

[fix] Shift-F5 being falsely inserted as 'S-F5'#2234

Merged
da-liii merged 1 commit intoMoganLab:branch-1.2from
JimZhouZZY:fix
Jun 5, 2025
Merged

[fix] Shift-F5 being falsely inserted as 'S-F5'#2234
da-liii merged 1 commit intoMoganLab:branch-1.2from
JimZhouZZY:fix

Conversation

@JimZhouZZY
Copy link
Contributor

What

Resolved the issue where Shift-F5 was incorrectly interpreted as S-F5 by adding a simple check: comb != "S-F5" during fallback.

Related: #2217

Why

Though this may not be the most elegant solution, it effectively addresses the issue for now, I think.

How to test your changes

  1. Build and run the project
  2. Enter math mode by typing $
  3. Press Shift+F5 or Shift+F5+I or Shift+F5+O or Shift+F5+U or Shift+F5+N (possibly with the Fn key)
  4. Verify that the integral sign is inserted, rather than the string S-F5

@JackYansongLi
Copy link
Contributor

这个好,我看了没问题。等明天沈达再review一下。

BTW,师弟加个微信,haggittli

@JackYansongLi
Copy link
Contributor

same problem as #2233

@JackYansongLi
Copy link
Contributor

JackYansongLi commented Jun 5, 2025

@da-liii macOS arm64的CI挂了,貌似和我本地端一个问题,看看是不是xmake的配置有问题

@JackYansongLi JackYansongLi requested a review from da-liii June 5, 2025 06:23
@JackYansongLi JackYansongLi self-assigned this Jun 5, 2025
@da-liii da-liii merged commit f7a6d02 into MoganLab:branch-1.2 Jun 5, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants