fix(lint): adjust eslint settings and fix warnings #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frgarc
approved these changes
Feb 19, 2025
| "no-throw-literal": "warn", | ||
| // turn off base rules as they can report incorrect errors | ||
| "no-unused-vars": "off", | ||
| "@typescript-eslint/no-unused-vars": ["warn", { "argsIgnorePattern": "^_" }] |
There was a problem hiding this comment.
Maybe we can add some others that we have implemented at PE repo:
'unicorn/no-null': ['error', { checkStrictEquality: true }],
'@typescript-eslint/no-floating-promises': ['error', { ignoreVoid: true }],
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defaults are coming from eslint:recommended from this section here:
With a few changes specific to the Google style guide and our codebase.
The config for naming conventions is mostly a copy of the default here
But with a few adjustments to allow snake_case properties, PascalCase globals, and PascalCase enum members.
Eventually we will turn off explicit-any when our protocol messages are properly typed.