-
Notifications
You must be signed in to change notification settings - Fork 80
Add QCManyBody and GenOptKing harnesses #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
loriab
wants to merge
19
commits into
MolSSI:master
Choose a base branch
from
loriab:qcmb_proc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files |
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Most of this is now covered in #466 — calling QCManyBody as a procedure and letting it call QCEngine programs for its inputs. This allows interaction energies or many-body expansions to arbitrary order with none, counterpoise, or VMFC basis set superposition error corrections. The "genopt" part is letting geometry optimizers act on a counterpoise-corrected gradient. This requires the OptimizationInput qcschema to specify manybody directions instead of single-point directions. This was handled through a "GeneralizedOptimizationInput/Result" for the QCManyBody paper, requiring schema in QCManyBody repo and geometric and optking harnesses here. But QCSchema v2 is going to handle this cleanly, so we're not going to push the genopt into master here.
Changelog description
Status