Enable getting properties directly from the server - #903
Draft
bennybp wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability for the dataset
get_properties_dffunction to call a new server endpoint instead. This endpoint will be much faster for many datasets by collecting all the information from the database in a single SQL query, rather than fetching and iterating over all records.As currently implemented, whether to use the server functionality or do it the old way is controlled by the
localparameter ofget_properties_df, withlocal = Truedoing it the old, slower way. The old way is also the only possible way to get properties when using views. I am open to other ideas, though.Needs to be tested against real-life, large datasets before merging
Status