Skip to content

Dataops 1178 update checkqc for projman #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 28, 2025
Merged

Dataops 1178 update checkqc for projman #134

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c9bb466
Updating illumina parser to return values for projman
nkongenelly Aug 21, 2025
09aae6f
Corrected tests after adding more details in qcData sequencing_metrics
nkongenelly Aug 27, 2025
c95b2ed
Refactored code
nkongenelly Sep 3, 2025
0ad571c
Testing GHA with python 3.11
nkongenelly Sep 3, 2025
ca0a8c5
Testing GHA with python 3.12
nkongenelly Sep 3, 2025
a9971fa
Testing GHA with python 3.13
nkongenelly Sep 3, 2025
4938558
Using python-versio matrix i GHA workflow
nkongenelly Sep 5, 2025
c1c2744
Update .github/workflows/unit_tests.yml
nkongenelly Sep 5, 2025
1e18686
Update .github/workflows/unit_tests.yml
nkongenelly Sep 5, 2025
ba0a7ed
removed pf_clusters from bclconvert sequencing metrics returned
nkongenelly Sep 15, 2025
5d7a453
Updated samplesheet v2 structure
nkongenelly Sep 24, 2025
394f852
Updated test data format
nkongenelly Sep 29, 2025
e3ae231
Made run_info available in qc_data and test_runfolders available in m…
nkongenelly Oct 6, 2025
9d971de
Added OverrideCycles in bclconvert samplesheet
nkongenelly Oct 8, 2025
a946b2a
Passing runfolder to qc_data_utils
nkongenelly Oct 20, 2025
861ea51
Added exception for bclconvert_test_runfolder
nkongenelly Oct 22, 2025
18b6e7e
Refactoring code
nkongenelly Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions checkQC/qc_data_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,4 +196,8 @@ def bclconvert_test_runfolder(qc_data, runfolder_path):
},
},
}
else:
raise Exception("Excpected flowcell_id value as 'HMTFYDRXX' only for "
f"this fuction but got {flowcell_id}"
Copy link
Collaborator

@matrulda matrulda Oct 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, there is a typo in the exception. Also, I thought the exception could be rephrased to something like this.

Suggested change
raise Exception("Excpected flowcell_id value as 'HMTFYDRXX' only for "
f"this fuction but got {flowcell_id}"
raise Exception("This function is only compatible with the run with flowcell_id: 'HMTFYDRXX', "
f"the supplied runfolder has flowcell_id: {flowcell_id}"

)