Skip to content

[doc] correct MCP #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 47 commits into
base: main
Choose a base branch
from
Open

[doc] correct MCP #8

wants to merge 47 commits into from

Conversation

bouthilx
Copy link

@bouthilx bouthilx commented Apr 11, 2025 •
edited by pr-agent-monadical bot
Loading

User description

nitpick 😬

PR Type

Documentation

Description

  • Fix incorrect MCP acronym expansion

Changes walkthrough 📝

Relevant files
Documentation
README.md
Fix incorrect MCP acronym expansion                                           

README.md

  • Corrected the expansion of MCP acronym from "Model Control Protocol"
    to "Model Context Protocol" in two places
    		• +2/-2     
    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
    •

    tito added 30 commits March 11, 2025 10:50
    @tito
    doc(readme): update readme to update tool call
    dd053de
    @tito
    doc(readme): remove license part
    5218784
    @tito
    fix: remove double connecting to message
    63734c5
    @tito
    feat(keys): pass local keys to the session by default
    167d73a
    @tito
    fix(langfuse): fix goose langfuse integration (wrong env variables)
    c56b4b3
    @tito
    fix(goose): remove MCP_HOST and such, this is not how mcp works
    00cee60
    @tito
    feat(config): add global user configuration for the tool
    7e2f807 
    - langfuse
- default driver
- and api keys
    @tito
    fix(session): fix session status display
    179e4fc
    @tito
    feat(volume): add the possibilty to mount local directory into the co…
    476529c 
    …ntainer (like docker volume)
    @tito
    fix(mc): fix runtime issue when starting mc
    2c9d143
    @tito
    refactor: move drivers directory into mcontainer package
    96a44ef 
    - Relocate goose driver to mcontainer/drivers/
- Update ConfigManager to dynamically scan for driver YAML files
- Add support for mc-driver.yaml instead of mai-driver.yaml
- Update Driver model to support init commands and other YAML fields
- Auto-discover drivers at runtime instead of hardcoding them
- Update documentation to reflect new directory structure
    @tito
    fix(goose): install latest goose version, do not use pip
    ac2d310
    @tito
    fix(goose): add ping, nano and vim to the default image
    0611dc9
    @tito
    feat(cli): support to join external network
    429aee2
    @tito
    feat(cli): separate session state into its own session.yaml file
    a4f1c88
    @tito
    feat(config): ensure config is correctly saved
    b120bba
    @tito
    feat(volume): add mc config volume command
    924166d
    @tito
    test: add unit tests
    65b0fcf
    @tito
    doc(mcp): add specification for mcp server support
    2f84bc1
    @tito
    feat(mcp): initial version of mcp
    c870eed
    @tito
    feat(mcp): first docker proxy working
    30e34cb
    @tito
    feat(mcp): add inspector
    36dbb83
    @tito
    feat(mcp): improve inspector reliability over re-run
    b215080
    @tito
    fix(session): ensure a session connect only to the mcp server passed …
    0e2e0ac 
    …in --mcp
    @tito
    feat(mcp): add the possibility to have default mcp to connect to
    a503364
    @tito
    feat(goose): optimize init status
    909ba03
    @tito
    feat(goose): auto add mcp server to goose configuration when starting…
    dd321d4 
    … a session
    @tito
    feat(mcp): ensure inner mcp environemnt variables are passed
    4b7ae39
    @tito
    feat(mc): support for uid/gid, and use default current user
    4423f75
    @tito
    feat(run): add --run command
    83f6ab9
    tito and others added 17 commits April 1, 2025 09:54
    @tito
    docs: Add --run option examples to README
    2110132
    @tito
    docs: Prefer mcx alias in README examples
    f8b8639
    @tito
    fix(uid): use symlink instead of volume for persistent volume in the …
    dd5b9ec 
    …container
    @tito
    fix(ssh): do not enable ssh automatically
    cbf2fad
    @tito
    chores: remove unecessary output
    c29af82
    @tito
    feat(ssh): make SSH server optional with --ssh flag
    150a6fe 
    - Added --ssh flag to session create command
- Modified mc-init.sh to check MC_SSH_ENABLED environment variable
- SSH server is now disabled by default
- Updated README.md with new flag example
- Fixed UnboundLocalError with container_name in exception handler
    @tito
    fix(mcp): fix UnboundLocalError: cannot access local variable 'contai…
    a7630ac 
    …ner_name' where it is not associated with a value
    @tito
    fix(goose): ensure configuration is run as user
    cf31c7c
    @tito
    feat(goose): update config using uv script with pyyaml (#6)
    1201eb2
    @tito
    feat(llm): add default model/provider to auto configure the driver (#7)
    5987585
    @tito
    fix(goose): always update the file
    638e2b2
    @tito
    fix(uid): correctly pass uid/gid to project
    623edea
    @tito
    feat(gemini): support for gemini model
    488715c
    @tito
    feat(project): explicitely add --project to save information in /mc-c…
    c869c11 
    …onfig across run.

Containers are now isolated by default.
    @tito
    fix: remove the "mc stop" meant to be in the container, but not imple…
    5b1afa0 
    …mented
    @tito
    refactor: reduce amount of data in session.yaml
    7421500
    @bouthilx
    [doc] correct MCP
    36269d6 
    nitpick 😬
    @pr-agent-monadical
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @pr-agent-monadical
    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers
    No reviews
    Assignees
    No one assigned
    Labels
    Review effort 1/5
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @bouthilx @tito