Conversation
Owner
Mongey
commented
Jun 5, 2025
Mongey
commented
- fix(resource_kafka_acl): fix ACL not found detection logic
- feat(resource_kafka_acl): add retry logic for ACL creation
- feat(resource_kafka_acl): add retry logic for ACL deletion
Fixed a bug in aclRead where the ACL detection logic was incorrect: - Changed from using aclNotFound=true to found=false for clearer logic - Fixed break statement to continue when no ACLs found for a resource - Properly set found=true when an exact ACL match is found - Inverted the final check to use \!found instead of aclNotFound This ensures ACLs are properly detected during read operations. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Added waitForACLToBeVisible function to ensure ACLs are visible in Kafka before aclCreate returns. This addresses race conditions where tests check for ACLs immediately after creation. The retry logic: - Attempts up to 10 times with 200ms intervals (2 seconds total) - Invalidates cache before each check to ensure fresh data - Checks for exact ACL match using string comparison - Respects context cancellation for proper timeout handling This ensures ACL creation operations complete successfully and are visible in Kafka before Terraform proceeds. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Added waitForACLToBeDeleted function to ensure ACLs are removed from Kafka before aclDelete returns. This addresses race conditions in tests and ensures consistent behavior. The retry logic: - Attempts up to 10 times with 200ms intervals (2 seconds total) - Invalidates cache before each check to ensure fresh data - Verifies ACL is no longer present using exact string comparison - Respects context cancellation for proper timeout handling This ensures ACL deletion operations complete successfully and ACLs are actually removed from Kafka before Terraform proceeds. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
Maybe it's related to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.