-
Notifications
You must be signed in to change notification settings - Fork 8
Add TgChat; Refactor Shit; God Help Us All #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…me hrefs missing `byond://`
Would you like me to implement "Examine More" like monkestation has? for things that have flavor text |
Please provide an example, as I have yet to try Main. If it's like TG where it says... "Examine again to look closer" for their scar system, sure. This additional text should carry over the Otherwise, examining an object once should give the base desc, if it's damaged, and if anything is attached to it (you can tape dead mice to walls and windows and doors. Also clothing accessories). |
… for me to figure out what the fuck caused this and I WAS THE CAUSE OF IT)
If we want to add double examines, that's going to have to be its own PR. there's a ton of entries with extra descriptions that we would have to convert. Also not everything needs to be a double examine. some things are simple like "It's melting apart!" don't need to be double examine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I REVIEWED EVERY DEUS FORSAKEN FILE. You hate me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
302 more files? More like
Nah
About The Pull Request
This is a MASSIVE PR that gets TGUI working, god have mercy on your soul if you decide to review this.
This ports a lot of stuff, some more incomplete than others. But the main goal was to get TgChat working, and other basic tgui stuff implemented.
SANITIZE_FILENAME
NO_TIMEZONE
to most timezone unrelated time2text callsglobal.dm
to GLOB.al variables.byond://
to hrefs that should have had it (516)CheckAdminHref
to admin topic calls\red
,\blue
, etc with theirspan
macro equivalents\icon
withicon2html
asay_color
preference for adminsThings to note!
Why It's Good For The Game
Erm... 516? Tgui chat good? Modern, not old af UI good? Genesis good? Dude i can't justify this PR but it improves so much.
Testing
Compiles, runs for the most part. UIs work. Some asset related things will runtime until asset transport is implemented in another PR.
Things to note:
ERROR: new asset added to the asset cache with the same name as another asset: objitemgunprojectileautomaticatreides.png existing asset hash: a0faa7918e78da5f7c6ec8a4169b92a3 new asset hash:903329d24b6238b9dea53e296e2831bd
)Changelog
🆑
add: Adds a lot. like a lot.
add: TGUI
admin: protected hrefs
add: Genesis
add: new config and logger methods
add: please just look at the PR #52
/:cl: