Skip to content

Add TgChat; Refactor Shit; God Help Us All #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Apr 14, 2025

Conversation

flleeppyy
Copy link
Member

@flleeppyy flleeppyy commented Apr 7, 2025

About The Pull Request

This is a MASSIVE PR that gets TGUI working, god have mercy on your soul if you decide to review this.

This ports a lot of stuff, some more incomplete than others. But the main goal was to get TgChat working, and other basic tgui stuff implemented.

Things to note!

  • Preps a bit for Tgui say, but won't work for until another PR since it involves macros and key combinations.
  • SERVER OPS: Please copy all the configuration files from config/example and start anew. There's a lot that has changed and you'll need to reconfigure your setup.

Why It's Good For The Game

Erm... 516? Tgui chat good? Modern, not old af UI good? Genesis good? Dude i can't justify this PR but it improves so much.

Testing

Compiles, runs for the most part. UIs work. Some asset related things will runtime until asset transport is implemented in another PR.

Things to note:

  • Asset sending will be broken for the mean time since it would also require porting webroot asset transport and stuff (aka stuff like ERROR: new asset added to the asset cache with the same name as another asset: objitemgunprojectileautomaticatreides.png existing asset hash: a0faa7918e78da5f7c6ec8a4169b92a3 new asset hash:903329d24b6238b9dea53e296e2831bd)
  • Most interfaces in the tgui package have been removed for sake of organization. If we don't have a use for it here, why include it? We'll slowly move things to Tgui over time, but most nanoui stuff will be left alone.

image

Changelog

🆑
add: Adds a lot. like a lot.
add: TGUI
admin: protected hrefs
add: Genesis
add: new config and logger methods
add: please just look at the PR #52
/:cl:

@flleeppyy flleeppyy changed the title [TGUI] Update to latest TGUI [TGUI] Add TgChat; Update to latest TGUI Apr 7, 2025
@Mycah142
Copy link
Collaborator

Mycah142 commented Apr 8, 2025

Current dislikes:
dreamseeker_msBAttHPMx
Admin logs are not obvious enough to admins.

dreamseeker_V6Hq2hugpR
Examining doesn't accurately reflect the actual icons, HUD additional text like Criminal Record or Medical Record are not a different font color, and accessories are not part of the examine text. (They need to be, there are accessories that also increase armor and the like, they should be visible one examine.)

dreamseeker_RGCFRrQYlO
And the new flavor text added to some equipment just looks like additional words, which used to bring up an Examine tab in the Statpanel that would also give even more information related to the item, such as antag text. (I just noticed that the new statpanel does not behave in this same way and I feel we might have lost some functionality somewhere along the way.)

These differ from Eris' tab-less chat, as shown:
dreamseeker_EByEzOI8Vt

I did like how examining did give a black background over the examine text, clearly defining it from other text. If this is reasonable to reimplement, huzzah. If not, well, I don't see the appeal of a multi-tab chat, sounds like chaos, but maybe I'll get used to it.

If possible, please address:
Admin Log Visibility (bigger, at the very least, shit should be loud)
HUD Additional Text Color (Medical Record, Security Record, Criminal Status, ect)
Uniform Accessory Visibility

Once addressed, I will approve it.

@flleeppyy
Copy link
Member Author

Would you like me to implement "Examine More" like monkestation has? for things that have flavor text

@flleeppyy flleeppyy marked this pull request as draft April 9, 2025 04:32
@Mycah142
Copy link
Collaborator

Mycah142 commented Apr 9, 2025

Would you like me to implement "Examine More" like monkestation has? for things that have flavor text

Please provide an example, as I have yet to try Main.

If it's like TG where it says... "Examine again to look closer" for their scar system, sure. This additional text should carry over the extra_description, description_antag (I am not even sure we have that var anymore with the stat panel change), and any other fluff text that might be included in the future (custom character descriptors is probably something you kids will want).

Otherwise, examining an object once should give the base desc, if it's damaged, and if anything is attached to it (you can tape dead mice to walls and windows and doors. Also clothing accessories).

@flleeppyy flleeppyy changed the title [TGUI] Add TgChat; Update to latest TGUI [TGUI] Add TgChat; Update Tgui; Add more shit Apr 10, 2025
@flleeppyy
Copy link
Member Author

Would you like me to implement "Examine More" like monkestation has? for things that have flavor text

Please provide an example, as I have yet to try Main.

If it's like TG where it says... "Examine again to look closer" for their scar system, sure. This additional text should carry over the extra_description, description_antag (I am not even sure we have that var anymore with the stat panel change), and any other fluff text that might be included in the future (custom character descriptors is probably something you kids will want).

Otherwise, examining an object once should give the base desc, if it's damaged, and if anything is attached to it (you can tape dead mice to walls and windows and doors. Also clothing accessories).

If we want to add double examines, that's going to have to be its own PR. there's a ton of entries with extra descriptions that we would have to convert. Also not everything needs to be a double examine. some things are simple like "It's melting apart!" don't need to be double examine

@flleeppyy
Copy link
Member Author

image
Fixed

@flleeppyy flleeppyy changed the title [TGUI] Add TgChat; Update Tgui; Add more shit Add TgChat; Refactor Shit; God Help Us All Apr 11, 2025
Copy link
Collaborator

@Mycah142 Mycah142 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I REVIEWED EVERY DEUS FORSAKEN FILE. You hate me.

@flleeppyy flleeppyy marked this pull request as ready for review April 14, 2025 22:11
Copy link
Collaborator

@Mycah142 Mycah142 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

302 more files? More like

Nah

@flleeppyy flleeppyy merged commit 739074e into Monkestation:master Apr 14, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants