Feature/static particle serializer #1044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AristurtleDev
added a commit
that referenced
this pull request
Oct 27, 2025
* Feature/static particle serializer (#1044) * Create ParticleEffectSerializer and add Deserialize methods * Add particle effect deserialize methods * Remove space in region directive * Update to use new ParticleEffectSerializer * Add unit tests for ParticleEffectSerializer * Mark ParticleEffectReader and ParticleEffectWriter as obsolete * Perform check for rooted path when loading textures * Add methods that allow for default values that don't throw exceptions * Deserialize using default values if attribute not found * Ensure that texture name is set when deserializing texture element * Read the enabled attribute for interpolators * Write the enabled attribute for modifiers and interpolators * Update tests * Update version to 5.2.0 (#1045)
AristurtleDev
added a commit
that referenced
this pull request
Oct 27, 2025
* Feature/static particle serializer (#1044) * Create ParticleEffectSerializer and add Deserialize methods * Add particle effect deserialize methods * Remove space in region directive * Update to use new ParticleEffectSerializer * Add unit tests for ParticleEffectSerializer * Mark ParticleEffectReader and ParticleEffectWriter as obsolete * Perform check for rooted path when loading textures * Add methods that allow for default values that don't throw exceptions * Deserialize using default values if attribute not found * Ensure that texture name is set when deserializing texture element * Read the enabled attribute for interpolators * Write the enabled attribute for modifiers and interpolators * Update tests * Update version to 5.2.0 (#1045) * Proivde deserailzie methods that don't rely on the content manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Consolidates the
ParticleEffectReaderandParticleEffectWriterinto a single staticParticleEffectSerializerclass. This ensures consistency with other .NET framework serializers likeJsonSerializerRelated Issues/Tickets
ParticleEffectReaderandParticleEffectWriterAs Static Class #1020Changes Made
ParticleEffectSerailizerclassParticleEffectReaderandParticleEffectWriteras obsolete. Will be removed in 6.0 as removing them would be a breaking change and major semver increase.Checklist
Please read and check the following items. Pull requests will not be reviewed if all items are not checked.