Skip to content

Conversation

@AristurtleDev
Copy link
Collaborator

Description

This PR changes the accessibility of four utility methods in ExtendedContentManager from private to protected, enabling developers to create derived classes without unnecessary code duplication. Additionally, XML documentation has been added to all previously undocumented members.

Related Issues/Tickets

Changes Made

  • Changed GetStream(string path) from private to protected
  • Changed CacheAsset(string name, object obj) from private to protected
  • Changed NoExtension(string name) from private to protected
  • Changed TryGetCachedAsset<T>(string name, out T asset) from private to protected
  • Added documentation to all members missing documentation
  • Added documentation to the methods that have changed from private to protected
  • Fixed issue with split documentation for the LoadTexturePacker between FNA/KNI and MonoGame implementations

Checklist

Please read and check the following items. Pull requests will not be reviewed if all items are not checked.

  • I have verified that there are no existing pull requests that would overlap with this pull request.
  • I have verified that I am following the guidelines as outlined in this project's contribution policy
  • I have verified that this pull request adheres to this project's code of conduct.
  • I have written a descriptive title for this pull request.
  • I have provided appropriate test coverage were applicable.

Marks `GetStream`, `CacheAsset`, `NoExtension` and `TryGetCachedAsset` as protected so that derived classes have access to them.

Closes #973
@AristurtleDev AristurtleDev self-assigned this Nov 2, 2025
@AristurtleDev AristurtleDev merged commit fc5aacb into develop Nov 2, 2025
1 check passed
@AristurtleDev AristurtleDev deleted the feature/extended-content-manager-method-access branch November 2, 2025 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change ExtendedContentManager method accessors

2 participants