Fix MacOS net8_mgfxc_wine_setup.sh #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some issues with the install script caused errors on macos. The default macos `grep` does not support the -P perl flag. So use a basic regex instead. We are trying to run `wine` in one part of the script, which will fail on M* Apple Macs because it is a 32bit executable. Also upgade to .net 8.0.401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some issues with the install script caused errors on macos. The default macos
grepdoes not support the -P perl flag. So use a basic regex instead.We are trying to run
winein one part of the script, which will fail on M* Apple Macs because it is a 32bit executable.Also upgade to .net 8.0.401