[WINE] Fix Wine script to work for version 10 #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CartBlanche
reviewed
Mar 12, 2025
| @@ -3,9 +3,15 @@ | |||
| # so that mgfxc can be run on Linux / macOS systems. | |||
|
|
|||
| # check dependencies | |||
| if ! type "wine64" > /dev/null 2>&1 | |||
| WINEEXECUTABLE="wine64" | |||
There was a problem hiding this comment.
@harry-cpp won't this still fail because it's still using wine64, instead of just wine?
There was a problem hiding this comment.
It shouldn't. If they have a previous version of wine installed, then it'll pick up the wine64 and use that, otherwise it falls back to just wine for the new version.
There was a problem hiding this comment.
It should be recommended that they have the newest version installed, or our docs need to lock it to a specific version otherwise.
There was a problem hiding this comment.
Nm, I missed some code further down.
CartBlanche
changed the title
CartBlanche
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #206