Separation Of Cash Payment From VendingMachineComponent by ThanosDeGraf · Pull Request #3871 · Monolith-Station/Monolith

ThanosDeGraf · 2026-04-24T12:07:57Z

About the PR

This PR tries to refactor all mentions of cash payment from VendingMachineComponeng (and hopefully VendingMachineSystem) into it's own areas. The new CreditReceiverComponent is a couple of attributes stolen and moved there. By giving baseVendingMachine the CreditReceiver parent, they should all function as they should before.

Later on, it should be possible to give non-vending machines this parent and allow em to process cash money for their features.

Why / Balance

The goal of this PR is to lay the foundation for more machines that can accept cash credit payment without access/need for a bank account. I've seperated out the refactoring into this PR for easier review as any change in behavior is unintended and should be more easily spotted. The other request is here #3913

Also, wanted content.
https://discord.com/channels/1329292619834069034/1431695702882386001/1494546272579752096

Media

Requirements

I have read relevant guidelines/documentation to this PR found on our devwiki.
I have added media to this PR or it does not require an ingame showcase.
I can confirm this PR contains either no AI-generated content, or AI-generated content that meets our guidelines.

How to test

Load up that game
grab some hard earned dosh
smack it in tha vendomat
punch that button fora cold one
watch your dosh disappear
enjoy the cold one with the lads

Breaking changes

Content.Server.VendingMachines.VendingMachineSystem.cs
Content.Client\VendingMachines\VendingMachineBoundUserInterface.cs
and sumsuch systems now use CreditReceiverComponent to check for the cash slot of a vending machine

New CreditReceiver abstract prototype that VendingMachine needs to inherit from.

An entity parented from VendingMachine that does NOT accept cash needs cashSlot: Null set in their CreditReceiver comp.

Changelog

No CL no fun.

This one still has an issue where the Vendomat doesn't update the GUI correctly until you purchase another update or re-insert the cash.

ThanosDeGraf · 2026-04-24T12:09:55Z

@Redrover1760 On draft as said on discord. This is probably very clumsy and not yet done since much of the actual payment logic is still stuck in VendingMachineSystem that I want to break out.

ThanosDeGraf · 2026-04-24T23:20:36Z

To be fair the "fix" is a bit clumsy, because it sort of needs to check for exactly VendingMachineBoundUserInterface to then update the UI. I've never worked with _uiSystem before, but I think removing that generic should do the trick

… void Update() There was an empty abstract Update method available already, so just use that like a sane person.

Finally! The component handling is one step closer to being seperated from vending machine behavior!

As a cool side effect, inserting cash into vends is now predicted!

looots of WiP still here.

for some reason the client bankComponent doesn't update before the bui.Update, so the bank balance is always one action behind.

Plus some comment edits.

Every entity parented from VendingMachine that does NOT accept cash needs `cashSlot: Null` in the CreditReceiver comp.

OneZerooo0

Crashes the server when an entity without a bank account tries inserting cash

ThanosDeGraf · 2026-05-20T14:38:42Z

Crashes the server when an entity without a bank account tries inserting cash

@OneZerooo0 I can't reproduce this, even when I spawn in a fresh monkey. The ATM just gives a pop-up saying "No Bank Account!" when I press Deposit. Do you still remember the exact sequence that causes the crash?

OneZerooo0 · 2026-05-20T19:30:42Z

When spawning a Urist and trying to put in cash, the localhost crashes

ThanosDeGraf · 2026-05-20T20:54:12Z

When spawning a Urist and trying to put in cash, the localhost crashes

On this PR at least, it's not happening

I'll update and see what happens IG.

ThanosDeGraf · 2026-05-21T13:16:20Z

Updated, still no crash with an urist. Any idea what it could be caused by @OneZerooo0 ?

github-actions · 2026-05-24T18:02:05Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

ThanosDeGraf · 2026-05-25T09:44:09Z

fixin this rn

Fuck off ilya and your 3000 file change commit.

Ilya246 · 2026-05-25T13:12:08Z

+    /// The type of currency to accept in the item slot.
+    /// </summary>
+    [DataField]
+    public string? CurrencyStackType;


use non-nullable ProtoId with a default value set to normal credits stack prototype

A protoID makes sense, as well as the default money ID, but making it non-nullable will be a massive pain the ass YAML side. Instead of only nulling CreditReceiver for the four vendors that dont need it, I have to add the component to every single vendor that DOES accept it EXCEPT the four special goobers.

no, you make a new base vendor type and reparent the ones that don't need credit receiver to it
so you have:

id: BaseVendomat ... id: BaseVendomatCredit parent: BaseVendomat

and parent vendomats accordingly

or make the first one BaseVendomatNoCredit and make the second one just BaseVendomat

Ilya246 · 2026-05-25T13:12:35Z

+    /// <summary>
+    /// Item slot for cash.</summary>
+    /// <remarks>
+    /// Set this to Null if you want to disable this component
+    /// in case you can't get rid of it, i.e. YAML inherited.
+    /// </remarks>
+    [DataField]
+    public ItemSlot? CashSlot;
+
+    /// <summary>
+    /// Name of the cash slot, if there is one.  Null if there isn't.
+    /// </summary>
+    [DataField]
+    public string? CashSlotName;


make non-nullable and remove relevant checks, the comp just shouldn't be added if not needed

See above. All vending machines inherit this component since they base-line expect to be credit receivers. It's only some vendors that don't want this component.

Ilya246 · 2026-05-25T13:17:22Z

+    }
+
+
+    protected void Update(Entity<CreditReceiverComponent> ent)


also don't need this and everything related anymore

I think you are referring to all the validation going on inside the Update method, and not saying you want me to obliterate the Update method. I will go with that.

your Update() seems to only handle the cached credits count variable which i told you to remove

Alrighty. As a heads up with that change it will probably take two weeks or more for me to get it done sine I'm on a vacation rn.

Ilya246 · 2026-05-25T13:18:43Z

+    /// Mono Change: Anything related to actually accepting physical cash or other currencies has been
+    /// moved over to <see cref="CreditReceiverComponent"/>. <seealso cref="CreditReceiverComponent.CashSlot"/>


remove, as well unneeded usings

Ilya246 · 2026-05-25T13:21:03Z

+- type: entity
+  id: CreditReceiver # Mono - Made it an abstract parent so any future changes for vending machines are less likely to break.
+  abstract: true
+  description: Allows the machine to accept payment with physical credit. Change the whitelist to allow for different currencies.
+  components:
+  - type: CreditReceiver
+    cashSlot:
+      whitelist:
+        components:
+        - Cash
+    cashSlotName: cash_slot
+    currencyStackType: Credit
+  - type: ItemSlots
+  - type: ContainerContainer
+    containers:
+      cash_slot: !type:ContainerSlot
+


should be its own file in _Mono considering this isn't just for vending machines

Ilya246 · 2026-05-26T14:24:15Z

also, use (Entity<Comp> ent, ref Event args) form of event subscription functions where you added new ones

ThanosDeGraf added 3 commits April 24, 2026 13:49

first commit!

ab97a11

This one still has an issue where the Vendomat doesn't update the GUI correctly until you purchase another update or re-insert the cash.

forgor one or two comments

6af9bf6

damn you rider

fdfba26

github-actions Bot added S: Untriaged C# YML size/M and removed S: Untriaged labels Apr 24, 2026

monolith8319 changed the title ~~Separation Of Cash Payment from VendingMachineComponent~~ Separation Of Cash Payment From VendingMachineComponent Apr 24, 2026

ThanosDeGraf commented Apr 24, 2026

View reviewed changes

Comment thread Content.Server/VendingMachines/VendingMachineSystem.cs Outdated

ThanosDeGraf added 2 commits April 25, 2026 01:02

Waho! Fixed the server/client component not replicating correctly

cb87433

Part of the fix, darn it rider!!

32066a9

ThanosDeGraf and others added 16 commits April 25, 2026 17:58

Renamed VendingMachineBoundUserInterface.Refresh() to public override…

3899ccd

… void Update() There was an empty abstract Update method available already, so just use that like a sane person.

SharedCreditReceiverSystem, moving OnVendingCashMoneyAfterState there.

30e0b2c

Finally! The component handling is one step closer to being seperated from vending machine behavior!

whoops, wrong namespace

6d12653

moved cashBalance updating from vendSys to SharedCreditReceiverSystem.cs

a1e0437

As a cool side effect, inserting cash into vends is now predicted!

I'll need this later

416baa1

saving work...

95c07cb

moving more logic...

1bfb8d0

looots of WiP still here.

One fixme down

8c666a5

more SharedCreditReceiverSystem.cs improvements

c6825e0

biiiiig move

5d7787c

for some reason the client bankComponent doesn't update before the bui.Update, so the bank balance is always one action behind.

raaagh

444fcdb

I actually dont need a bunch of these

a24fc04

empty-b-gone

ef0508b

fixme down

53e1261

new API method that returns an int instead of a bool.

e270b58

Plus some comment edits.

Merge branch 'main' into CreditReceiver-Created

cd319ce

ThanosDeGraf marked this pull request as ready for review April 29, 2026 12:40

ThanosDeGraf mentioned this pull request Apr 29, 2026

Added Shipyard Creditslot #3913

Closed

5 tasks

ThanosDeGraf added 5 commits April 29, 2026 18:08

fix linter errors

bcc999b

Merge branch 'main' into CreditReceiver-Created

a6ab072

Fixed yaml errors

93f69c5

Every entity parented from VendingMachine that does NOT accept cash needs `cashSlot: Null` in the CreditReceiver comp.

Added some more comments

73b4471

buh

70c2415

OneZerooo0 requested changes May 16, 2026

View reviewed changes

Merge branch 'main' into CreditReceiver-Created

8c6418d

Ilya246 self-requested a review May 22, 2026 09:45

github-actions Bot added S: Needs Review S: Merge Conflict labels May 22, 2026

merged "main" into my-fuckass-branch

49fac4f

github-actions Bot removed the S: Merge Conflict label May 25, 2026

Ilya246 requested changes May 25, 2026

View reviewed changes

MantasDab360 mentioned this pull request Jun 15, 2026

Ship Cashslots #4106

Closed

3 tasks

Merge branch 'main' into CreditReceiver-Created

6a259e9

		/// Mono Change: Anything related to actually accepting physical cash or other currencies has been
		/// moved over to <see cref="CreditReceiverComponent"/>. <seealso cref="CreditReceiverComponent.CashSlot"/>

Uh oh!

Conversation

ThanosDeGraf commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

About the PR

Why / Balance

Media

Requirements

How to test

Breaking changes

Uh oh!

ThanosDeGraf commented Apr 24, 2026

Uh oh!

Uh oh!

ThanosDeGraf commented Apr 24, 2026

Uh oh!

OneZerooo0 left a comment

Choose a reason for hiding this comment

Uh oh!

ThanosDeGraf commented May 20, 2026

Uh oh!

OneZerooo0 commented May 20, 2026

Uh oh!

ThanosDeGraf commented May 20, 2026

Uh oh!

ThanosDeGraf commented May 21, 2026

Uh oh!

github-actions Bot commented May 24, 2026

Uh oh!

ThanosDeGraf commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ilya246 May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ilya246 commented May 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ThanosDeGraf commented Apr 24, 2026 •

edited

Loading

ThanosDeGraf commented May 25, 2026 •

edited

Loading

Ilya246 May 26, 2026 •

edited

Loading