Fixes issues with update_all, increment, and decrement#15
Merged
Conversation
…emfiles, use linux/amd64 in docker-compose.yml
MonsidoMiqe
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upstream PR citusdata#223 broke some usages of update_all. Both increment and decrement use update_all.
For example a call to
model.decrement!(:counter)generates an UPDATE query withSET "counter" = NULLinstead of the correctSET "counter" = COALESCE("counter", 0).The bug was noticed 7 months after the PR that introduced it was created
https://github.com/citusdata/activerecord-multi-tenant/pull/223/files#r1743665204
the author of the above comment Laykou and another user Amit909Singh discussed the issue (all comments can be seen in the PR citusdata#223) and Amit909Singh mentioned they fixed it in citusdata#223 (comment)
I cherry-picked his commit Amit909Singh@c08b636
and
incrementanddecrementI also submitted a PR upstream, but the gem is abandoned so I doubt it will ever get merged.
citusdata#282