Improves implementation of generic types #43
Conversation
lukasoyen
left a comment
lukasoyen
left a comment
There was a problem hiding this comment.
Looks good!
- License headers
- Nice code -
everyThingIsAwesome - Tests
Could you write a few words on why Windows is no longer supported and bump the JDK version in .travis-ci.yml to make Travis happy?
If Travis is happy, I am happy :)
| @@ -0,0 +1,30 @@ | |||
| #Dont use maven directly, because all maven dependencies downloaded during build time won't be in the image | |||
There was a problem hiding this comment.
Do we need a dockerfile? I guess it's fine.
| You can also install Graphviz to generate class diagrams. This is optional. | ||
|
|
||
| choco install graphviz | ||
| Currently Windows is not supported. |
There was a problem hiding this comment.
Could you expand on why Windows is not supported anymore?
There was a problem hiding this comment.
There were a few reasons.
One that i can remember is reading from command line produces different line endings. So the unit tests fail on windows.
| <compilerSource>1.7</compilerSource> | ||
| <compilerCompliance>1.7</compilerCompliance> | ||
| <compilerTargetPlatform>1.7</compilerTargetPlatform> | ||
| <compilerSource>1.8</compilerSource> |
There was a problem hiding this comment.
I think we need a JDK version bump in the .travis-ci.yml aswell, to make Travis happy.
| } | ||
| } | ||
|
|
||
| if(everyThingIsAwesome) { |
| for (VariableDeclaration variableDeclaration : parameters) { | ||
| visitor.visitDoubleDispatched(variableDeclaration); | ||
| } | ||
| // if(wrapperFunctionObjectDeclaration != null){ |
There was a problem hiding this comment.
Unnecessary code is unnecessary (happens a few times)? Yet again, I don't really care.
|
And you could update https://github.com/MontysCoconut/moco/blob/master/FEATURES.md :) |
2 participants
No description provided.