Skip to content

Conversation

@dentiny
Copy link
Collaborator

@dentiny dentiny commented Oct 20, 2025

Summary

The bug is:

  • On recovery, we send out commit LSN and replication LSN as the latest iceberg snapshot LSN
  • But later, we update commit LSN with the commit message we receive (which is the commit message body end LSN)
  • It leads to a problem: end LSN could be smaller than our the recovered LSN, which leads to LSN regression
  • This PR fixes it by re-using the same strategy as replication LSN, which only updates channel value when a larger LSN is met

Related Issues

Closes #2165

Checklist

  • Code builds correctly
  • Tests have been added or updated
  • Documentation updated if necessary
  • I have reviewed my own changes

cursor[bot]

This comment was marked as outdated.

@dentiny dentiny merged commit c1a99ef into Mooncake-Labs:main Oct 20, 2025
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: LSN regression on table recovery

1 participant