item loading optimizations, fix search hint text translation

[harleykradovill]

Pull Request

Summary

This PR contains various performance improvements within Moonfin. It backports commits from upstream and expands on them, providing loading speed improvements for search, episode lists, and tv show extras. This also fixes an issue where the hint text on the search screen would translate upward after clearing the search box. It also replaces an unnecessarily large circle64.png with another existing image, since existing uses would scale the image down anyways even though the app loaded the full image.

Type of Change

• Bug fix
• New feature
• Refactor
• Performance improvement
• UI/UX update
• Documentation update
• Build/CI change
• Other (describe):

Changes Made

• Backported e0f6ec3 and 68dabe7 from upstream which improved loading time of episodes.
• Expanded on those commits, and made similar changes to searchMedia and TVSeasonExtras. These changes made noticeable search speed improvements. I found that a 10 second search now only takes 3 seconds. The issue was that the app loaded images for every search result immediately. Now, it loads images only after the search completes and the rows are displayed.
• Moved the help text out of the layout group, because the text would shift up and down when performing a search and then clearing the search box. I also adjusted the translations of the hint text and searchRows so they align.
• Moved searchBox.bs and searchBox.xml in to the search folder.
• Replaced circle64.png with circle.png. There was no need for two images, especially since circle64.png is 1000x1000px but is displayed at a maximum size of only 250px.

Testing

• Tested on physical Roku device
• Tested via sideload
• Manual testing completed
• Not tested (explain why):

Checklist

• Code builds successfully
• Code follows project style and conventions
• No unnecessary commented-out code
• No new warnings introduced

[1hitsong]

Thank you for cherry picking the commits instead of just copying & pasting the code so ferezvi retains credit for their work 🤘🏻

[harleykradovill]

Thank you for cherry picking the commits instead of just copying & pasting the code so ferezvi retains credit for their work 🤘🏻

For sure!