Skip to content

updated quick connect sign-in flow#119

Open
harleykradovill wants to merge 3 commits into
Moonfin-Client:masterfrom
harleykradovill:signin
Open

updated quick connect sign-in flow#119
harleykradovill wants to merge 3 commits into
Moonfin-Client:masterfrom
harleykradovill:signin

Conversation

@harleykradovill

Copy link
Copy Markdown
Collaborator

Pull Request

Summary

This PR changes the sign-in flow to be more like Moonfin-Core. It shows the Quick Connect code in the main sign-in group itself, puts Quick Connect and Password in to tabs, and defaults to Quick Connect when detected in server.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

  • Moved Quick Connect from a dialog to be displayed on the signInGroup itself. This involved moving the functions from QuickConnectDialog to SigninScene. QuickConnectDialog.bs/.xml was removed since it is no longer used.
  • Added 2 tabs, Quick Connect and Password, to switch between quick connect and the conventional username/password signInFormContainer.
  • Added a check when initializing SigninScene to detect if Quick Connect is enabled on the server. If it is, we default to the Quick Connect tab.

Testing

  • Tested on physical Roku device
  • Tested via sideload
  • Manual testing completed
  • Not tested (explain why):

Screenshots

screenshot-2026-06-25-19 59 06 588 screenshot-2026-06-25-19 59 20 240

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant