updated quick connect sign-in flow#119
Open
harleykradovill wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
This PR changes the sign-in flow to be more like Moonfin-Core. It shows the Quick Connect code in the main sign-in group itself, puts Quick Connect and Password in to tabs, and defaults to Quick Connect when detected in server.
Type of Change
Changes Made
signInGroupitself. This involved moving the functions fromQuickConnectDialogtoSigninScene.QuickConnectDialog.bs/.xmlwas removed since it is no longer used.Quick ConnectandPassword, to switch between quick connect and the conventional username/passwordsignInFormContainer.SigninSceneto detect if Quick Connect is enabled on the server. If it is, we default to the Quick Connect tab.Testing
Screenshots
Checklist