feat: optimize _update_per_bucket_p2p logic#28
Merged
weixiao-huang merged 26 commits intoMoonshotAI:mainfrom Oct 29, 2025
Merged
feat: optimize _update_per_bucket_p2p logic#28weixiao-huang merged 26 commits intoMoonshotAI:mainfrom
weixiao-huang merged 26 commits intoMoonshotAI:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the P2P (peer-to-peer) update logic by merging the _update_per_bucket_p2p function with the existing _update_per_bucket function and implementing a topology-aware receiver assignment strategy to maximize bandwidth utilization.
- Consolidated P2P and broadcast update logic into a single unified function
- Added RDMA device topology awareness for optimal receiver assignment
- Enhanced metadata structures to include RDMA device information
Comments suppressed due to low confidence (1)
checkpoint_engine/ps.py:1
- This line was removed but
self._current_global_parameter_metasis still being used later in the function without proper initialization. This could cause issues if the dictionary is not properly initialized elsewhere.
from __future__ import annotations
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: specture724 <149605198+specture724@users.noreply.github.com>
Signed-off-by: specture724 <149605198+specture724@users.noreply.github.com>
…-engine into feat/optimize_p2p
specture724
commented
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #25
Merge _update_per_bucket_p2p with _update_per_bucket. Topology-awared receiver assignment strategy implemented to make full use of bandwidth