Skip to content

fix destroy process group error when using p2p update #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weixiao-huang merged 1 commit into from
Oct 13, 2025
Merged

fix destroy process group error when using p2p update #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion checkpoint_engine/ps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,13 +792,15 @@ def update(
self.init_process_group()
self._update_per_bucket(checkpoint_name, req_func)
else:
if self._rank not in ranks:
if not self._auto_pg and self._rank not in ranks:
return
if self._auto_pg:
if dist.is_initialized():
dist.destroy_process_group()
# HACK: wait 2s to ensure destroy is finished
time.sleep(2)
if self._rank not in ranks:
return
self.init_process_group_for_ranks(ranks)
self._update_per_bucket_p2p(checkpoint_name, req_func, ranks)
if self._auto_pg:
Expand Down