Skip to content

fix: use correct type for _current_global_parameter_metas #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weixiao-huang merged 1 commit into from
Oct 14, 2025
+6 −1
Merged

fix: use correct type for _current_global_parameter_metas #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion checkpoint_engine/ps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,7 +725,12 @@ def gather_metas(self, checkpoint_name: str):
if not self._global_device_uuids:
global_device_uuids.append(metas_buckets.device_uuid)
if metas_buckets.memory_buffer_metas_list:
self._current_global_parameter_metas[i] = metas_buckets
# _current_global_parameter_metas value should be MemoryBufferMetaList, but metas_buckets is DataToGather
# so we need to convert it to MemoryBufferMetaList
self._current_global_parameter_metas[i] = MemoryBufferMetaList(
memory_buffer_metas_list=metas_buckets.memory_buffer_metas_list,
p2p_store_addr=metas_buckets.p2p_store_addr,
)
num_parameters += sum(len(x.metas) for x in metas_buckets.memory_buffer_metas_list)
if not self._all_hosts:
self._all_hosts = all_hosts
Expand Down