fix: propagate remote exception traceback to parameter server#59
Merged
weixiao-huang merged 1 commit intoMoonshotAI:mainfrom Dec 5, 2025
Merged
fix: propagate remote exception traceback to parameter server#59weixiao-huang merged 1 commit intoMoonshotAI:mainfrom
weixiao-huang merged 1 commit intoMoonshotAI:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves error handling in the distributed checkpoint engine by propagating full exception tracebacks from remote workers to the parameter server, rather than just exception messages. This enhancement addresses a debugging issue introduced in PR #43 where remote exceptions were being caught but their tracebacks were silently dropped.
Key changes:
- Workers now format full exception tracebacks as strings using
traceback.format_exception()before sending them to the parameter server - Parameter server logs the complete traceback information instead of just exception type and message
- Error messages are now more informative for debugging remote worker failures
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| checkpoint_engine/worker.py | Added traceback import and modified exception handlers to format and send complete traceback strings instead of exception objects |
| checkpoint_engine/ps.py | Updated error response handling to receive and log traceback strings instead of parsing exception objects |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
specture724
reviewed
Dec 3, 2025
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #43 we have been catching
remote exceptions instead of letting them crash the process. However, only the
exception message was propagated back and logged, and the original traceback
was silently dropped. This makes it hard to debug issues that happen in remote workers.
This PR changes the error handling to also return the full remote traceback
alongside the exception object, and ensures the parameter server logs it.