fix: correct module-name type in pyproject.toml #774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change module-name from array to string in [tool.uv.build-backend] section to fix TOML parse error during `make prepare`. The uv build backend expects module-name to be a string, not a sequence. This was causing the error: "invalid type: sequence, expected a string"
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a TOML parse error that prevented make prepare from running successfully. The uv build backend was incorrectly configured with module-name as an array instead of a string across all workspace packages.
Changes:
- Corrected
module-nameconfiguration format from array to string in all pyproject.toml files - Applied fix consistently across root project and all 4 workspace packages
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Changed module-name from array ["kimi_cli"] to string "kimi_cli" |
| packages/kaos/pyproject.toml | Changed module-name from array ["kaos"] to string "kaos" |
| packages/kimi-code/pyproject.toml | Changed module-name from array ["kimi_code"] to string "kimi_code" |
| packages/kosong/pyproject.toml | Changed module-name from array ["kosong"] to string "kosong" |
| sdks/kimi-sdk/pyproject.toml | Changed module-name from array ["kimi_sdk"] to string "kimi_sdk" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Running
make preparefails with a TOML parse error:error: Failed to parse: pyproject.toml
Caused by: TOML parse error at line 52, column 15
|
52 | module-name = ["kimi_cli"]
| ^^^^^^^^^^^^
invalid type: sequence, expected a string
The uv build backend expects
module-nameto be a string, not a sequence.This error was present in all workspace packages.
Related Issue
N/A - This is a straightforward configuration bug fix discovered during setup.
Description
Changed
module-namein[tool.uv.build-backend]section from array format to string format across all workspace packages.Changes:
pyproject.toml:module-name = ["kimi_cli"]→module-name = "kimi_cli"packages/kaos/pyproject.toml:module-name = ["kaos"]→module-name = "kaos"packages/kimi-code/pyproject.toml:module-name = ["kimi_code"]→module-name = "kimi_code"packages/kosong/pyproject.toml:module-name = ["kosong"]→module-name = "kosong"sdks/kimi-sdk/pyproject.toml:module-name = ["kimi_sdk"]→module-name = "kimi_sdk"Testing
After this fix,
make preparecompletes successfully without TOML parse errors.