feat: ✨ optimize BSP confirm flow #670
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so the BSP empties its queue of storage requests to confirm more efficiently, by always trying to send the confirm extrinsic with the maximum amount of confirms allowed by the runtime instead of being happy sending it with less than that.
PopConfirmStoringRequestscommand, and can then filter them in two lists with theFilterConfirmStoringRequests: the ones ready to confirm and the ones pending that the volunteer extrinsic is included in the blockchain.Short description
There is a new new runtime API under the File System pallet:
get_max_batch_confirm_storage_requests. Runtime managers of runtimes that use StorageHub will have to implement it.Who is affected
Suggested code changes
Implement the runtime API: